]> git.itanic.dy.fi Git - linux-stable/commit
[PATCH] NAT: Fix module refcount dropping too far
authorRusty Rusty <rusty@rustcorp.com.au>
Tue, 15 Nov 2005 12:32:36 +0000 (13:32 +0100)
committerChris Wright <chrisw@osdl.org>
Thu, 24 Nov 2005 22:10:08 +0000 (14:10 -0800)
commit0012c3a76ba77f505ac94be3780f010926bef3ee
treec5e31368a409aa5f1dff5be30c16d47d53b1bcb1
parent63cb535137220bc764b2c6def34843acb53e99f3
[PATCH] NAT: Fix module refcount dropping too far

The unknown protocol is used as a fallback when a protocol isn't known.
Hence we cannot handle it failing, so don't set ".me".  It's OK, since we
only grab a reference from within the same module (iptable_nat.ko), so we
never take the module refcount from 0 to 1.

Also, remove the "protocol is NULL" test: it's never NULL.

Signed-off-by: Rusty Rusty <rusty@rustcorp.com.au>
Signed-off-by: Harald Welte <laforge@netfilter.org>
Signed-off-by: Chris Wright <chrisw@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/ipv4/netfilter/ip_nat_core.c
net/ipv4/netfilter/ip_nat_proto_unknown.c