]> git.itanic.dy.fi Git - linux-stable/commit
net: moxa: fix UAF in moxart_mac_probe
authorPavel Skripkin <paskripkin@gmail.com>
Fri, 9 Jul 2021 14:09:53 +0000 (17:09 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Jul 2021 07:12:34 +0000 (09:12 +0200)
commit001e04bd5d48444917e7c3261d01e391803fcb55
tree6ea7d1312b7f2a7e4b038d5ef252acfd2981de13
parent5a37be80709cc038189b7cfc4324693b48f09520
net: moxa: fix UAF in moxart_mac_probe

commit c78eaeebe855fd93f2e77142ffd0404a54070d84 upstream.

In case of netdev registration failure the code path will
jump to init_fail label:

init_fail:
netdev_err(ndev, "init failed\n");
moxart_mac_free_memory(ndev);
irq_map_fail:
free_netdev(ndev);
return ret;

So, there is no need to call free_netdev() before jumping
to error handling path, since it can cause UAF or double-free
bug.

Fixes: 6c821bd9edc9 ("net: Add MOXA ART SoCs ethernet driver")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/moxa/moxart_ether.c