]> git.itanic.dy.fi Git - linux-stable/commit
net/dim: Update DIM start sample after each DIM iteration
authorTal Gilboa <talgi@mellanox.com>
Wed, 21 Nov 2018 14:28:23 +0000 (16:28 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 22 Nov 2018 19:36:54 +0000 (11:36 -0800)
commit0211dda68a4f6531923a2f72d8e8959207f59fba
tree1c50a0a281fd47b17ed6fe90a99577c51f6b9636
parent426a593e641ebf0d9288f0a2fcab644a86820220
net/dim: Update DIM start sample after each DIM iteration

On every iteration of net_dim, the algorithm may choose to
check for the system state by comparing current data sample
with previous data sample. After each of these comparison,
regardless of the action taken, the sample used as baseline
is needed to be updated.

This patch fixes a bug that causes DIM to take wrong decisions,
due to never updating the baseline sample for comparison between
iterations. This way, DIM always compares current sample with
zeros.

Although this is a functional fix, it also improves and stabilizes
performance as the algorithm works properly now.

Performance:
Tested single UDP TX stream with pktgen:
samples/pktgen/pktgen_sample03_burst_single_flow.sh -i p4p2 -d 1.1.1.1
-m 24:8a:07:88:26:8b -f 3 -b 128

ConnectX-5 100GbE packet rate improved from 15-19Mpps to 19-20Mpps.
Also, toggling between profiles is less frequent with the fix.

Fixes: 8115b750dbcb ("net/dim: use struct net_dim_sample as arg to net_dim")
Signed-off-by: Tal Gilboa <talgi@mellanox.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/net_dim.h