]> git.itanic.dy.fi Git - linux-stable/commit
PCI: Fix pci_create_slot() reference count leak
authorQiushi Wu <wu000273@umn.edu>
Thu, 28 May 2020 02:13:22 +0000 (21:13 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Sep 2020 09:24:20 +0000 (11:24 +0200)
commit03f4e517e6ac202d6a6ca50f02a1319a4a70cdd6
treef216612b2db55108cbb69ce92c721a0b64581c4c
parent1c33c23b931d0b0e38aa436a90c2c527414e2fc5
PCI: Fix pci_create_slot() reference count leak

[ Upstream commit 8a94644b440eef5a7b9c104ac8aa7a7f413e35e5 ]

kobject_init_and_add() takes a reference even when it fails.  If it returns
an error, kobject_put() must be called to clean up the memory associated
with the object.

When kobject_init_and_add() fails, call kobject_put() instead of kfree().

b8eb718348b8 ("net-sysfs: Fix reference count leak in
rx|netdev_queue_add_kobject") fixed a similar problem.

Link: https://lore.kernel.org/r/20200528021322.1984-1-wu000273@umn.edu
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pci/slot.c