]> git.itanic.dy.fi Git - linux-stable/commit
ACPI: CPPC: Fix bit_offset shift in MASK_VAL() macro
authorJarred White <jarredwhite@linux.microsoft.com>
Tue, 9 Apr 2024 05:23:09 +0000 (22:23 -0700)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 22 Apr 2024 16:42:16 +0000 (18:42 +0200)
commit05d92ee782eeb7b939bdd0189e6efcab9195bf95
treeaa42476f62a17211b07e9557f197894baea731d3
parented30a4a51bb196781c8058073ea720133a65596f
ACPI: CPPC: Fix bit_offset shift in MASK_VAL() macro

Commit 2f4a4d63a193 ("ACPI: CPPC: Use access_width over bit_width for
system memory accesses") neglected to properly wrap the bit_offset shift
when it comes to applying the mask. This may cause incorrect values to be
read and may cause the cpufreq module not be loaded.

[   11.059751] cpu_capacity: CPU0 missing/invalid highest performance.
[   11.066005] cpu_capacity: partial information: fallback to 1024 for all CPUs

Also, corrected the bitmask generation in GENMASK (extra bit being added).

Fixes: 2f4a4d63a193 ("ACPI: CPPC: Use access_width over bit_width for system memory accesses")
Signed-off-by: Jarred White <jarredwhite@linux.microsoft.com>
Cc: 5.15+ <stable@vger.kernel.org> # 5.15+
Reviewed-by: Vanshidhar Konda <vanshikonda@os.amperecomputing.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/cppc_acpi.c