]> git.itanic.dy.fi Git - linux-stable/commit
packet: read num_members once in packet_rcv_fanout()
authorEric Dumazet <edumazet@google.com>
Tue, 16 Jun 2015 14:59:11 +0000 (07:59 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Jul 2015 17:37:56 +0000 (10:37 -0700)
commit06f6b596d3bde14318753a243dea62b80b3fc26f
tree88195cb16fdbb509f16eb34431b720e3abb77a88
parent6a3334dd56ef82f556c13adf41a035e0c205ac34
packet: read num_members once in packet_rcv_fanout()

[ Upstream commit f98f4514d07871da7a113dd9e3e330743fd70ae4 ]

We need to tell compiler it must not read f->num_members multiple
times. Otherwise testing if num is not zero is flaky, and we could
attempt an invalid divide by 0 in fanout_demux_cpu()

Note bug was present in packet_rcv_fanout_hash() and
packet_rcv_fanout_lb() but final 3.1 had a simple location
after commit 95ec3eb417115fb ("packet: Add 'cpu' fanout policy.")

Fixes: dc99f600698dc ("packet: Add fanout support.")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/packet/af_packet.c