]> git.itanic.dy.fi Git - linux-stable/commit
tls: fix lockless read of strp->msg_ready in ->poll
authorSabrina Dubroca <sd@queasysnail.net>
Wed, 24 Apr 2024 10:25:47 +0000 (12:25 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 25 Apr 2024 15:32:37 +0000 (08:32 -0700)
commit0844370f8945086eb9335739d10205dcea8d707b
tree4be7d487609af271fc19ce111974738fe30417e9
parent38d7b94e81d068b8d8c8392f421cfd2c3bbfd1a6
tls: fix lockless read of strp->msg_ready in ->poll

tls_sk_poll is called without locking the socket, and needs to read
strp->msg_ready (via tls_strp_msg_ready). Convert msg_ready to a bool
and use READ_ONCE/WRITE_ONCE where needed. The remaining reads are
only performed when the socket is locked.

Fixes: 121dca784fc0 ("tls: suppress wakeups unless we have a full record")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Link: https://lore.kernel.org/r/0b7ee062319037cf86af6b317b3d72f7bfcd2e97.1713797701.git.sd@queasysnail.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/tls.h
net/tls/tls.h
net/tls/tls_strp.c