]> git.itanic.dy.fi Git - linux-stable/commit
scsi: libsas: Fix error path in sas_notify_lldd_dev_found()
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 5 Sep 2020 12:58:36 +0000 (15:58 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 23 Sep 2020 10:40:40 +0000 (12:40 +0200)
commit09aadf40322545ab0d8e828e344e1834ea1d110c
tree7d92099f77f62e681598bca23e0d759209b917c3
parent9afe751494197a58660e3b19e9fc8ab5c48bf643
scsi: libsas: Fix error path in sas_notify_lldd_dev_found()

[ Upstream commit 244359c99fd90f1c61c3944f93250f8219435c75 ]

In sas_notify_lldd_dev_found(), if we can't allocate the necessary
resources, then it seems like the wrong thing to mark the device as found
and to increment the reference count.  None of the callers ever drop the
reference in that situation.

[mkp: tweaked commit desc based on feedback from John]

Link: https://lore.kernel.org/r/20200905125836.GF183976@mwanda
Fixes: 735f7d2fedf5 ("[SCSI] libsas: fix domain_device leak")
Reviewed-by: Jason Yan <yanaijie@huawei.com>
Acked-by: John Garry <john.garry@huawei.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/libsas/sas_discover.c