]> git.itanic.dy.fi Git - linux-stable/commit
ALSA: aoa: onyx: always initialize register read value
authorJohannes Berg <johannes@sipsolutions.net>
Mon, 29 Jul 2019 07:14:22 +0000 (09:14 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jan 2020 09:21:46 +0000 (10:21 +0100)
commit09deaf6acad81fffcbf11c4c7f86cdf83854aff1
treea22acee276df233f87654bb21743799ad1f6c32b
parent7638131006ea80bb4fffa7d01c8038490062d7d0
ALSA: aoa: onyx: always initialize register read value

[ Upstream commit f474808acb3c4b30552d9c59b181244e0300d218 ]

A lot of places in the driver use onyx_read_register() without
checking the return value, and it's been working OK for ~10 years
or so, so probably never fails ... Rather than trying to check the
return value everywhere, which would be relatively intrusive, at
least make sure we don't use an uninitialized value.

Fixes: f3d9478b2ce4 ("[ALSA] snd-aoa: add snd-aoa")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/aoa/codecs/onyx.c