]> git.itanic.dy.fi Git - linux-stable/commit
fs/xattr.c: zero out memory copied to userspace in getxattr
authorMichal Hocko <mhocko@suse.com>
Mon, 8 May 2017 22:57:24 +0000 (15:57 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 26 Aug 2017 01:14:47 +0000 (02:14 +0100)
commit0dc00866575aef50d8c15fda0d6b220630d4fde5
tree5fca29a0f4c17172aba222adece32ec1edfb1eb1
parent988a86df7d858492574003b624c9db7a9c9e3d9c
fs/xattr.c: zero out memory copied to userspace in getxattr

commit 81be3dee96346fbe08c31be5ef74f03f6b63cf68 upstream.

getxattr uses vmalloc to allocate memory if kzalloc fails.  This is
filled by vfs_getxattr and then copied to the userspace.  vmalloc,
however, doesn't zero out the memory so if the specific implementation
of the xattr handler is sloppy we can theoretically expose a kernel
memory.  There is no real sign this is really the case but let's make
sure this will not happen and use vzalloc instead.

Fixes: 779302e67835 ("fs/xattr.c:getxattr(): improve handling of allocation failures")
Link: http://lkml.kernel.org/r/20170306103327.2766-1-mhocko@kernel.org
Acked-by: Kees Cook <keescook@chromium.org>
Reported-by: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/xattr.c