]> git.itanic.dy.fi Git - linux-stable/commit
ubifs: Fix wrong orphan node deletion in ubifs_jnl_update|rename
authorZhihao Cheng <chengzhihao1@huawei.com>
Tue, 7 Jul 2020 12:51:40 +0000 (20:51 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Aug 2020 11:07:38 +0000 (13:07 +0200)
commit0e5b183b6d6936bf7256cd657f12d1f5beb8049e
treea482b55c36eeb63181cd46936bcd7630f380ad3e
parentcc03f4be0a15e70f56981750a9d84ab7613921ea
ubifs: Fix wrong orphan node deletion in ubifs_jnl_update|rename

[ Upstream commit 094b6d1295474f338201b846a1f15e72eb0b12cf ]

There a wrong orphan node deleting in error handling path in
ubifs_jnl_update() and ubifs_jnl_rename(), which may cause
following error msg:

  UBIFS error (ubi0:0 pid 1522): ubifs_delete_orphan [ubifs]:
  missing orphan ino 65

Fix this by checking whether the node has been operated for
adding to orphan list before being deleted,

Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Fixes: 823838a486888cf484e ("ubifs: Add hashes to the tree node cache")
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/ubifs/journal.c