]> git.itanic.dy.fi Git - linux-stable/commit
selinux: handle TCP SYN-ACK packets correctly in selinux_ip_postroute()
authorPaul Moore <pmoore@redhat.com>
Wed, 4 Dec 2013 21:10:51 +0000 (16:10 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 3 Jan 2014 04:33:31 +0000 (04:33 +0000)
commit117bd60788c1cfd2281a62cbc0d32798725cfd23
tree2a48f29f6cd8511961e2312035e1045f7feebf82
parentc726922d43fcd4db302f181a98bd0a54dc6c86f4
selinux: handle TCP SYN-ACK packets correctly in selinux_ip_postroute()

commit 446b802437f285de68ffb8d6fac3c44c3cab5b04 upstream.

In selinux_ip_postroute() we perform access checks based on the
packet's security label.  For locally generated traffic we get the
packet's security label from the associated socket; this works in all
cases except for TCP SYN-ACK packets.  In the case of SYN-ACK packet's
the correct security label is stored in the connection's request_sock,
not the server's socket.  Unfortunately, at the point in time when
selinux_ip_postroute() is called we can't query the request_sock
directly, we need to recreate the label using the same logic that
originally labeled the associated request_sock.

See the inline comments for more explanation.

Reported-by: Janak Desai <Janak.Desai@gtri.gatech.edu>
Tested-by: Janak Desai <Janak.Desai@gtri.gatech.edu>
Signed-off-by: Paul Moore <pmoore@redhat.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
security/selinux/hooks.c