]> git.itanic.dy.fi Git - linux-stable/commit
random: schedule jitter credit for next jiffy, not in two jiffies
authorJason A. Donenfeld <Jason@zx2c4.com>
Fri, 30 Sep 2022 22:31:00 +0000 (00:31 +0200)
committerJason A. Donenfeld <Jason@zx2c4.com>
Sat, 1 Oct 2022 10:04:21 +0000 (12:04 +0200)
commit122733471384be8c23f019fbbd46bdf7be561dcd
tree9f8678593ea57807688d88acc212ecbbc6543ae3
parent4c95236a335d8b62aa8dbd587bed6a5f30d8265a
random: schedule jitter credit for next jiffy, not in two jiffies

Counterintuitively, mod_timer(..., jiffies + 1) will cause the timer to
fire not in the next jiffy, but in two jiffies. The way to cause
the timer to fire in the next jiffy is with mod_timer(..., jiffies).
Doing so then lets us bump the upper bound back up again.

Fixes: 50ee7529ec45 ("random: try to actively add entropy rather than passively wait for it")
Fixes: 829d680e82a9 ("random: cap jitter samples per bit to factor of HZ")
Cc: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Sultan Alsawaf <sultan@kerneltoast.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
drivers/char/random.c