]> git.itanic.dy.fi Git - linux-stable/commit
s390/vdso: drop '-fPIC' from LDFLAGS
authorNathan Chancellor <nathan@kernel.org>
Wed, 31 Jan 2024 03:14:28 +0000 (20:14 -0700)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:16:41 +0000 (18:16 -0400)
commit16b95141495811001dd6ae6707e26ef71033d705
treea360faf42b6856005162e9f57398fff9d2003377
parentc4056851c0a3fdd401fa8a6367e36e1b2dc998ec
s390/vdso: drop '-fPIC' from LDFLAGS

[ Upstream commit 0628c03934187be33942580e10bb9afcc61adeed ]

'-fPIC' as an option to the linker does not do what it seems like it
should. With ld.bfd, it is treated as '-f PIC', which does not make
sense based on the meaning of '-f':

  -f SHLIB, --auxiliary SHLIB Auxiliary filter for shared object symbol table

When building with ld.lld (currently under review in a GitHub pull
request), it just errors out because '-f' means nothing and neither does
'-fPIC':

  ld.lld: error: unknown argument '-fPIC'

'-fPIC' was blindly copied from CFLAGS when the vDSO stopped being
linked with '$(CC)', it should not be needed. Remove it to clear up the
build failure with ld.lld.

Fixes: 2b2a25845d53 ("s390/vdso: Use $(LD) instead of $(CC) to link vDSO")
Link: https://github.com/llvm/llvm-project/pull/75643
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Fangrui Song <maskray@google.com>
Link: https://lore.kernel.org/r/20240130-s390-vdso-drop-fpic-from-ldflags-v1-1-094ad104fc55@kernel.org
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/s390/kernel/vdso32/Makefile
arch/s390/kernel/vdso64/Makefile