]> git.itanic.dy.fi Git - linux-stable/commit
OPP: Fix -Wunsequenced in _of_add_opp_table_v1()
authorNathan Chancellor <nathan@kernel.org>
Thu, 5 Oct 2023 17:25:27 +0000 (10:25 -0700)
committerViresh Kumar <viresh.kumar@linaro.org>
Fri, 6 Oct 2023 07:19:29 +0000 (12:49 +0530)
commit184ff4f721638e37a5a5907bf98962b6d9318ef6
tree35f44bc10cb25c53349425e8a94a79b70963699b
parent693bb8a4d1a762058c5dbf42fb95a567931f706e
OPP: Fix -Wunsequenced in _of_add_opp_table_v1()

Clang warns (or errors with CONFIG_WERROR=y):

  drivers/opp/of.c:1081:28: error: multiple unsequenced modifications to 'val' [-Werror,-Wunsequenced]
   1081 |                         .freq = be32_to_cpup(val++) * 1000,
        |                                                 ^
   1082 |                         .u_volt = be32_to_cpup(val++),
        |                                                   ~~
  1 error generated.

There is no sequence point in a designated initializer. Move back to
separate variables for the creation of the values, so that there are
sequence points between each evaluation and increment of val.

Fixes: 75bbc92c09d8 ("OPP: Add dev_pm_opp_add_dynamic() to allow more flexibility")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/opp/of.c