]> git.itanic.dy.fi Git - linux-stable/commit
net: mediatek: mtk_eth_soc: clear MAC_MCR_FORCE_LINK only when MAC is up
authorDaniel Golle <daniel@makrotopia.org>
Wed, 13 Mar 2024 22:50:18 +0000 (22:50 +0000)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:17:33 +0000 (18:17 -0400)
commit1a16fb6a44aa4d4efa920dad4c805dba4c48f2ef
tree9d6340efcdc2f141d90d8e1681dffd5b8cadcb88
parent43c8a525cbc5c8ff9d12bd8917bfaa376a29279d
net: mediatek: mtk_eth_soc: clear MAC_MCR_FORCE_LINK only when MAC is up

[ Upstream commit f1b85ef15a99f06ed48871ce933d591127d2dcc0 ]

Clearing bit MAC_MCR_FORCE_LINK which forces the link down too early
can result in MAC ending up in a broken/blocked state.

Fix this by handling this bit in the .mac_link_up and .mac_link_down
calls instead of in .mac_finish.

Fixes: b8fc9f30821e ("net: ethernet: mediatek: Add basic PHYLINK support")
Suggested-by: Mason-cw Chang <Mason-cw.Chang@mediatek.com>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/mediatek/mtk_eth_soc.c