]> git.itanic.dy.fi Git - linux-stable/commit
net: phy: prevent stale pointer dereference in phy_init()
authorVladimir Oltean <vladimir.oltean@nxp.com>
Thu, 20 Jul 2023 00:02:31 +0000 (03:02 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 20 Jul 2023 19:47:25 +0000 (12:47 -0700)
commit1c613beaf877c0c0d755853dc62687e2013e55c4
treebe1b4cb15b5788097c277e7840fe92acc8976f62
parent7998c0ad4c89cbb0bcd1594d9f989c8a5853daf7
net: phy: prevent stale pointer dereference in phy_init()

mdio_bus_init() and phy_driver_register() both have error paths, and if
those are ever hit, ethtool will have a stale pointer to the
phy_ethtool_phy_ops stub structure, which references memory from a
module that failed to load (phylib).

It is probably hard to force an error in this code path even manually,
but the error teardown path of phy_init() should be the same as
phy_exit(), which is now simply not the case.

Fixes: 55d8f053ce1b ("net: phy: Register ethtool PHY operations")
Link: https://lore.kernel.org/netdev/ZLaiJ4G6TaJYGJyU@shell.armlinux.org.uk/
Suggested-by: Russell King (Oracle) <linux@armlinux.org.uk>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/20230720000231.1939689-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/phy_device.c