]> git.itanic.dy.fi Git - linux-stable/commit
net: dsa: qca8k: remove leftover phy accessors
authorChristian Lamparter <chunkeey@gmail.com>
Fri, 22 Mar 2019 00:05:02 +0000 (01:05 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 26 Mar 2019 17:47:10 +0000 (10:47 -0700)
commit1eec7151ae0e134bd42e3f128066b2ff8da21393
tree06ac4548bf74368cc71062107f5981be2f647e2c
parent5e07321f3388e6f2b13c43ae9df3e09efa8418e0
net: dsa: qca8k: remove leftover phy accessors

This belated patch implements Andrew Lunn's request of
"remove the phy_read() and phy_write() functions."
<https://lore.kernel.org/patchwork/comment/902734/>

While seemingly harmless, this causes the switch's user
port PHYs to get registered twice. This is because the
DSA subsystem will create a slave mdio-bus not knowing
that the qca8k_phy_(read|write) accessors operate on
the external mdio-bus. So the same "bus" gets effectively
duplicated.

Cc: stable@vger.kernel.org
Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family")
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/qca8k.c