]> git.itanic.dy.fi Git - linux-stable/commit
of: fdt: fix off-by-one error in unflatten_dt_nodes()
authorSergey Shtylyov <s.shtylyov@omp.ru>
Sat, 13 Aug 2022 20:34:16 +0000 (23:34 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 Sep 2022 12:14:01 +0000 (14:14 +0200)
commit2133f451311671c7c42b5640d2b999326b39aa0e
treed67006cab01d952ddff7032e3f797ef9769ff8f9
parentb80678c1e00a34f01bce79c27afb7555666f559f
of: fdt: fix off-by-one error in unflatten_dt_nodes()

[ Upstream commit 2f945a792f67815abca26fa8a5e863ccf3fa1181 ]

Commit 78c44d910d3e ("drivers/of: Fix depth when unflattening devicetree")
forgot to fix up the depth check in the loop body in unflatten_dt_nodes()
which makes it possible to overflow the nps[] buffer...

Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.

Fixes: 78c44d910d3e ("drivers/of: Fix depth when unflattening devicetree")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/7c354554-006f-6b31-c195-cdfe4caee392@omp.ru
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/of/fdt.c