]> git.itanic.dy.fi Git - linux-stable/commit
ALSA: sb: Fix potential double-free of CSP mixer elements
authorTakashi Iwai <tiwai@suse.de>
Tue, 8 Jun 2021 14:04:37 +0000 (16:04 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jul 2021 14:22:41 +0000 (16:22 +0200)
commit25325ef39a58cf4e4b7247eef23de713194cf3e6
tree33c85d49795830057f6f7596141e52b4ff9da93f
parent31c99ad8243c28a875e852916091ee69e83e5a90
ALSA: sb: Fix potential double-free of CSP mixer elements

[ Upstream commit c305366a37441c2ac90b08711cb6f032b43672f2 ]

snd_sb_qsound_destroy() contains the calls of removing the previously
created mixer controls, but it doesn't clear the pointers.  As
snd_sb_qsound_destroy() itself may be repeatedly called via ioctl,
this could lead to double-free potentially.

Fix it by clearing the struct fields properly afterwards.

Link: https://lore.kernel.org/r/20210608140540.17885-4-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/isa/sb/sb16_csp.c