]> git.itanic.dy.fi Git - linux-stable/commit
md: raid1: fix potential OOB in raid1_remove_disk()
authorZhang Shurong <zhang_shurong@foxmail.com>
Sat, 22 Jul 2023 07:53:53 +0000 (15:53 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 Sep 2023 09:00:04 +0000 (11:00 +0200)
commit25a68f2286be56fb3a6f9fa0e269c04b5e6c6e24
tree0a2a3655c5130b3ad42661b9698db972d2d4d0d1
parent77918680ab078363338860334b170fc1b7334f65
md: raid1: fix potential OOB in raid1_remove_disk()

[ Upstream commit 8b0472b50bcf0f19a5119b00a53b63579c8e1e4d ]

If rddev->raid_disk is greater than mddev->raid_disks, there will be
an out-of-bounds in raid1_remove_disk(). We have already found
similar reports as follows:

1) commit d17f744e883b ("md-raid10: fix KASAN warning")
2) commit 1ebc2cec0b7d ("dm raid: fix KASAN warning in raid5_remove_disk")

Fix this bug by checking whether the "number" variable is
valid.

Signed-off-by: Zhang Shurong <zhang_shurong@foxmail.com>
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/tencent_0D24426FAC6A21B69AC0C03CE4143A508F09@qq.com
Signed-off-by: Song Liu <song@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/md/raid1.c