]> git.itanic.dy.fi Git - linux-stable/commit
drm: renesas: shmobile: Fix overlay plane disable
authorGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 15 Sep 2023 08:53:19 +0000 (10:53 +0200)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 16 Oct 2023 09:47:43 +0000 (11:47 +0200)
commit28675d45a3810c7302979b9803b18814d357c650
treee38996c4777514b5ede8a92da7722ce4376cda5e
parentc68ab8b5ea53aa0895f7ec5b72c87e0f7097761e
drm: renesas: shmobile: Fix overlay plane disable

Merely writing zero to the CHn Source Image Format Register is not
sufficient to disable a plane, as the programmed register value is not
propagated immediately to the current side.  This can be seen when using
the -P option of modetest: the extra plane is displayed correctly, but
does not disappear after exit.

Fix this by doing the full update dance using the Blend Control
Register, like is done when enabling the plane.

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/54e2556e18b5524ce153a7ac79faf2c7b0a55260.1694767209.git.geert+renesas@glider.be
drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c