]> git.itanic.dy.fi Git - linux-stable/commit
svcrpc: fix svc_xprt_enqueue/svc_recv busy-looping
authorJ. Bruce Fields <bfields@redhat.com>
Fri, 17 Aug 2012 21:31:53 +0000 (17:31 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 Sep 2012 17:00:39 +0000 (10:00 -0700)
commit299ee067572cf58dd38d03770263cbca212e5332
tree7fe1fb1336c14637aeb989d154fd741bfc22d128
parente684493e06addddaf273964dff6fa0f2204953b8
svcrpc: fix svc_xprt_enqueue/svc_recv busy-looping

commit d10f27a750312ed5638c876e4bd6aa83664cccd8 upstream.

The rpc server tries to ensure that there will be room to send a reply
before it receives a request.

It does this by tracking, in xpt_reserved, an upper bound on the total
size of the replies that is has already committed to for the socket.

Currently it is adding in the estimate for a new reply *before* it
checks whether there is space available.  If it finds that there is not
space, it then subtracts the estimate back out.

This may lead the subsequent svc_xprt_enqueue to decide that there is
space after all.

The results is a svc_recv() that will repeatedly return -EAGAIN, causing
server threads to loop without doing any actual work.

Reported-by: Michael Tokarev <mjt@tls.msk.ru>
Tested-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/sunrpc/svc_xprt.c