]> git.itanic.dy.fi Git - linux-stable/commit
cxl/region: Flag partially torn down regions as unusable
authorDan Williams <dan.j.williams@intel.com>
Sat, 17 Jun 2023 01:24:34 +0000 (18:24 -0700)
committerDan Williams <dan.j.williams@intel.com>
Sun, 25 Jun 2023 20:45:40 +0000 (13:45 -0700)
commit2ab47045ac96a605e3037d479a7d5854570ee5bf
tree4930bd13b8c12be472fc8b2f7f0f6c3c32550753
parentd1257d098a5a38753a0736a50db0a26a62377ad7
cxl/region: Flag partially torn down regions as unusable

cxl_region_decode_reset() walks all the decoders associated with a given
region and disables them. Due to decoder ordering rules it is possible
that a switch in the topology notices that a given decoder can not be
shutdown before another region with a higher HPA is shutdown first. That
can leave the region in a partially committed state.

Capture that state in a new CXL_REGION_F_NEEDS_RESET flag and require
that a successful cxl_region_decode_reset() attempt must be completed
before cxl_region_probe() accepts the region.

This is a corollary for the bug that Jonathan identified in "CXL/region
:  commit reset of out of order region appears to succeed." [1].

Cc: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Link: http://lore.kernel.org/r/20230316171441.0000205b@Huawei.com
Fixes: 176baefb2eb5 ("cxl/hdm: Commit decoder state to hardware")
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/168696507423.3590522.16254212607926684429.stgit@dwillia2-xfh.jf.intel.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/cxl/core/region.c
drivers/cxl/cxl.h