]> git.itanic.dy.fi Git - linux-stable/commit
ARM: zynq: Use memcpy_toio instead of memcpy on smp bring-up
authorLuis Araneda <luaraneda@gmail.com>
Thu, 8 Aug 2019 12:52:43 +0000 (08:52 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 5 Oct 2019 13:12:23 +0000 (15:12 +0200)
commit2dcea73cea85bd395fcbc2e491a2c91c90a605a6
tree89d09a07ab32b3f72e1c06f39083c3264dc91b9a
parentc2d30ffe4cabd6a4bb084304262df6fa282ac069
ARM: zynq: Use memcpy_toio instead of memcpy on smp bring-up

commit b7005d4ef4f3aa2dc24019ffba03a322557ac43d upstream.

This fixes a kernel panic on memcpy when
FORTIFY_SOURCE is enabled.

The initial smp implementation on commit aa7eb2bb4e4a
("arm: zynq: Add smp support")
used memcpy, which worked fine until commit ee333554fed5
("ARM: 8749/1: Kconfig: Add ARCH_HAS_FORTIFY_SOURCE")
enabled overflow checks at runtime, producing a read
overflow panic.

The computed size of memcpy args are:
- p_size (dst): 4294967295 = (size_t) -1
- q_size (src): 1
- size (len): 8

Additionally, the memory is marked as __iomem, so one of
the memcpy_* functions should be used for read/write.

Fixes: aa7eb2bb4e4a ("arm: zynq: Add smp support")
Signed-off-by: Luis Araneda <luaraneda@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm/mach-zynq/platsmp.c