]> git.itanic.dy.fi Git - linux-stable/commit
net: ipa: generic command param fix
authorAlex Elder <elder@linaro.org>
Wed, 8 Feb 2023 20:56:45 +0000 (14:56 -0600)
committerDavid S. Miller <davem@davemloft.net>
Fri, 10 Feb 2023 08:06:31 +0000 (08:06 +0000)
commit2df181f09c961377a55510a864216d48d787fe49
treed1f80ac682826f99955b2103d09adce6337f4561
parent47400aaea4ffdc306f0fd698f8c13b02e133130e
net: ipa: generic command param fix

Starting at IPA v4.11, the GSI_GENERIC_COMMAND GSI register got a
new PARAMS field.  The code that encodes a value into that field
sets it unconditionally, which is wrong.

We currently only provide 0 as the field's value, so this error has
no real effect.  Still, it's a bug, so let's fix it.

Fix an (unrelated) incorrect comment as well.  Fields in the
ERROR_LOG GSI register actually *are* defined for IPA versions
prior to v3.5.1.

Fixes: fe68c43ce388 ("net: ipa: support enhanced channel flow control")
Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ipa/gsi.c
drivers/net/ipa/gsi_reg.h