]> git.itanic.dy.fi Git - linux-stable/commit
net: ravb: Fix RX byte accounting for jumbo packets
authorPaul Barker <paul.barker.ct@bp.renesas.com>
Tue, 16 Apr 2024 12:02:54 +0000 (13:02 +0100)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 18 Apr 2024 09:34:28 +0000 (11:34 +0200)
commit2e36c9fbc476f95a1b19e3fa0a2cdf408475ff56
tree8a6e5237607f27fa26cd2536bff3746ae3057bb2
parentc7c449502b51c5b5de79f97a42be750b28f6ecee
net: ravb: Fix RX byte accounting for jumbo packets

The RX byte accounting for jumbo packets was changed to fix a potential
use-after-free bug. However, that fix used the wrong variable and so
only accounted for the number of bytes in the final descriptor, not the
number of bytes in the whole packet.

To fix this, we can simply update our stats with the correct number of
bytes before calling napi_gro_receive().

Also rename pkt_len to desc_len in ravb_rx_gbeth() to avoid any future
confusion. The variable name pkt_len is correct in ravb_rx_rcar() as
that function does not handle packets spanning multiple descriptors.

Fixes: 5a5a3e564de6 ("ravb: Fix potential use-after-free in ravb_rx_gbeth()")
Signed-off-by: Paul Barker <paul.barker.ct@bp.renesas.com>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/renesas/ravb_main.c