]> git.itanic.dy.fi Git - linux-stable/commit
btrfs: clarify error returns values in __load_free_space_cache
authorZhihao Cheng <chengzhihao1@huawei.com>
Fri, 20 Nov 2020 01:08:04 +0000 (09:08 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Mar 2021 16:44:36 +0000 (17:44 +0100)
commit2f36ef5863955893af5a99e0b2d73c8e2b6401a4
tree92aed8528ae26eb231c982b7ed908ec61062fbe2
parentafe8372892ceecc9e06ea894a9b81424d2db11c7
btrfs: clarify error returns values in __load_free_space_cache

[ Upstream commit 3cc64e7ebfb0d7faaba2438334c43466955a96e8 ]

Return value in __load_free_space_cache is not properly set after
(unlikely) memory allocation failures and 0 is returned instead.
This is not a problem for the caller load_free_space_cache because only
value 1 is considered as 'cache loaded' but for clarity it's better
to set the errors accordingly.

Fixes: a67509c30079 ("Btrfs: add a io_ctl struct and helpers for dealing with the space cache")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/btrfs/free-space-cache.c