]> git.itanic.dy.fi Git - linux-stable/commit
autofs: Fix automounts by using current_real_cred()->uid
authorEric W. Biederman <ebiederm@xmission.com>
Fri, 30 Sep 2016 16:28:05 +0000 (11:28 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 Oct 2016 10:40:24 +0000 (12:40 +0200)
commit2f9aa718353fb59909ae032620dd2eb958d6d7c5
tree7074c9504a089f0703c548e05b7d350efe080524
parentdfca701b1084eb3a5ab806088ff5008039f71ce7
autofs: Fix automounts by using current_real_cred()->uid

commit 069d5ac9ae0d271903cc4607890616418118379a upstream.

Seth Forshee reports that in 4.8-rcN some automounts are failing
because the requesting the automount changed.

The relevant call path is:
follow_automount()
    ->d_automount
    autofs4_d_automount
       autofs4_mount_wait
           autofs4_wait

In autofs4_wait wq_uid and wq_gid are set to current_uid() and
current_gid respectively.  With follow_automount now overriding creds
uid that we export to userspace changes and that breaks existing
setups.

To remove the regression set wq_uid and wq_gid from
current_real_cred()->uid and current_real_cred()->gid respectively.
This restores the current behavior as current->real_cred is identical
to current->cred except when override creds are used.

Fixes: aeaa4a79ff6a ("fs: Call d_automount with the filesystems creds")
Reported-by: Seth Forshee <seth.forshee@canonical.com>
Tested-by: Seth Forshee <seth.forshee@canonical.com>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/autofs4/waitq.c