]> git.itanic.dy.fi Git - linux-stable/commit
drm/nouveau/kms: Fix backlight registration
authorHans de Goede <hdegoede@redhat.com>
Sun, 26 Mar 2023 20:54:33 +0000 (22:54 +0200)
committerHans de Goede <hdegoede@redhat.com>
Wed, 29 Mar 2023 10:02:47 +0000 (12:02 +0200)
commit30fb97ba4a8e082ba0a5432479d6995472edbd7b
tree6859c35e887d8b2230d104e7d6971ffe8bafcc28
parent34224133458ca48caf2b57df335e870f1abb7af5
drm/nouveau/kms: Fix backlight registration

The nouveau code used to call drm_fb_helper_initial_config() from
nouveau_fbcon_init() before calling drm_dev_register(). This would
probe all connectors so that drm_connector->status could be used during
backlight registration which runs from nouveau_connector_late_register().

After commit 4a16dd9d18a0 ("drm/nouveau/kms: switch to drm fbdev helpers")
the fbdev emulation code, which now is a drm-client, can only run after
drm_dev_register(). So during backlight registration the connectors are
not probed yet and the drm_connector->status == connected check in
nv50_backlight_init() would now always fail.

Replace the drm_connector->status == connected check with
a drm_helper_probe_detect() == connected check to fix nv_backlight
no longer getting registered because of this.

Fixes: 4a16dd9d18a0 ("drm/nouveau/kms: switch to drm fbdev helpers")
Link: https://gitlab.freedesktop.org/drm/nouveau/-/issues/202
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2181941
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230326205433.36485-1-hdegoede@redhat.com
drivers/gpu/drm/nouveau/nouveau_backlight.c