]> git.itanic.dy.fi Git - linux-stable/commit
mm: lock newly mapped VMA which can be modified after it becomes visible
authorSuren Baghdasaryan <surenb@google.com>
Sat, 8 Jul 2023 19:12:11 +0000 (12:12 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 8 Jul 2023 21:08:02 +0000 (14:08 -0700)
commit33313a747e81af9f31d0d45de78c9397fa3655eb
tree9e4050107b487128f0b628c7b7117082953e23eb
parentc137381f71aec755fbf47cd4e9bd4dce752c054c
mm: lock newly mapped VMA which can be modified after it becomes visible

mmap_region adds a newly created VMA into VMA tree and might modify it
afterwards before dropping the mmap_lock.  This poses a problem for page
faults handled under per-VMA locks because they don't take the mmap_lock
and can stumble on this VMA while it's still being modified.  Currently
this does not pose a problem since post-addition modifications are done
only for file-backed VMAs, which are not handled under per-VMA lock.
However, once support for handling file-backed page faults with per-VMA
locks is added, this will become a race.

Fix this by write-locking the VMA before inserting it into the VMA tree.
Other places where a new VMA is added into VMA tree do not modify it
after the insertion, so do not need the same locking.

Cc: stable@vger.kernel.org
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/mmap.c