]> git.itanic.dy.fi Git - linux-stable/commit
wifi: mac80211: do not abuse fq.lock in ieee80211_do_stop()
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Sun, 17 Jul 2022 12:21:52 +0000 (21:21 +0900)
committerKalle Valo <kvalo@kernel.org>
Mon, 18 Jul 2022 12:01:14 +0000 (15:01 +0300)
commit3598cb6e18626d28d20c8de4ee8217fdd4153d63
treeee18f0a6e77d37f73c0ceba6b0214ae1c90c20bc
parentbcfd9d7f6840b06d5988c7141127795cf405805e
wifi: mac80211: do not abuse fq.lock in ieee80211_do_stop()

lockdep complains use of uninitialized spinlock at ieee80211_do_stop() [1],
for commit f856373e2f31ffd3 ("wifi: mac80211: do not wake queues on a vif
that is being stopped") guards clear_bit() using fq.lock even before
fq_init() from ieee80211_txq_setup_flows() initializes this spinlock.

According to discussion [2], Toke was not happy with expanding usage of
fq.lock. Since __ieee80211_wake_txqs() is called under RCU read lock, we
can instead use synchronize_rcu() for flushing ieee80211_wake_txqs().

Link: https://syzkaller.appspot.com/bug?extid=eceab52db7c4b961e9d6
Link: https://lkml.kernel.org/r/874k0zowh2.fsf@toke.dk
Reported-by: syzbot <syzbot+eceab52db7c4b961e9d6@syzkaller.appspotmail.com>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Fixes: f856373e2f31ffd3 ("wifi: mac80211: do not wake queues on a vif that is being stopped")
Tested-by: syzbot <syzbot+eceab52db7c4b961e9d6@syzkaller.appspotmail.com>
Acked-by: Toke Høiland-Jørgensen <toke@kernel.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/9cc9b81d-75a3-3925-b612-9d0ad3cab82b@I-love.SAKURA.ne.jp
net/mac80211/iface.c