]> git.itanic.dy.fi Git - linux-stable/commit
xfs: handle nimaps=0 from xfs_bmapi_write in xfs_alloc_file_space
authorChristoph Hellwig <hch@lst.de>
Wed, 11 Oct 2023 05:16:26 +0000 (07:16 +0200)
committerChandan Babu R <chandanbabu@kernel.org>
Mon, 23 Oct 2023 05:36:54 +0000 (11:06 +0530)
commit35dc55b9e80cb9ec4bcb969302000b002b2ed850
treeb6494e0ecbcdd14cf6874311a6830fcc20e306e3
parent2b99e410b28f5a75ae417e6389e767c7745d6fce
xfs: handle nimaps=0 from xfs_bmapi_write in xfs_alloc_file_space

If xfs_bmapi_write finds a delalloc extent at the requested range, it
tries to convert the entire delalloc extent to a real allocation.

But if the allocator cannot find a single free extent large enough to
cover the start block of the requested range, xfs_bmapi_write will
return 0 but leave *nimaps set to 0.

In that case we simply need to keep looping with the same startoffset_fsb
so that one of the following allocations will eventually reach the
requested range.

Note that this could affect any caller of xfs_bmapi_write that covers
an existing delayed allocation.  As far as I can tell we do not have
any other such caller, though - the regular writeback path uses
xfs_bmapi_convert_delalloc to convert delayed allocations to real ones,
and direct I/O invalidates the page cache first.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
fs/xfs/xfs_bmap_util.c