]> git.itanic.dy.fi Git - linux-stable/commit
hwmon: (nzxt-kraken2) Fix error handling path in kraken2_probe()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 3 Dec 2023 15:24:05 +0000 (16:24 +0100)
committerGuenter Roeck <linux@roeck-us.net>
Sun, 3 Dec 2023 17:07:26 +0000 (09:07 -0800)
commit35fe2ad259a3bfca15ab78c8ffb5278cb6149c89
tree7337dd14adce938f1942cfa741ad30365f8eb62b
parent1fefca6c57fb928d2131ff365270cbf863d89c88
hwmon: (nzxt-kraken2) Fix error handling path in kraken2_probe()

There is no point in calling hid_hw_stop() if hid_hw_start() has failed.
There is no point in calling hid_hw_close() if hid_hw_open() has failed.

Update the error handling path accordingly.

Fixes: 82e3430dfa8c ("hwmon: add driver for NZXT Kraken X42/X52/X62/X72")
Reported-by: Aleksa Savic <savicaleksa83@gmail.com>
Closes: https://lore.kernel.org/all/121470f0-6c1f-418a-844c-7ec2e8a54b8e@gmail.com/
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Jonas Malaco <jonas@protocubo.io>
Link: https://lore.kernel.org/r/a768e69851a07a1f4e29f270f4e2559063f07343.1701617030.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/nzxt-kraken2.c