]> git.itanic.dy.fi Git - linux-stable/commit
nl80211: check netlink protocol in socket release notification
authorDmitry Ivanov <dmitrijs.ivanovs@ubnt.com>
Wed, 6 Apr 2016 14:23:18 +0000 (17:23 +0300)
committerWilly Tarreau <w@1wt.eu>
Tue, 7 Jun 2016 08:42:51 +0000 (10:42 +0200)
commit3af67b1b6b4d3dc6e05bdb76aa1a3d2c4f185630
treed0c836173f144c8f905c7076ed3fe37a76378f64
parentb0b535780e3b4ddc29c76bafddf54d2c4f933322
nl80211: check netlink protocol in socket release notification

commit 8f815cdde3e550e10c2736990d791f60c2ce43eb upstream.

A non-privileged user can create a netlink socket with the same port_id as
used by an existing open nl80211 netlink socket (e.g. as used by a hostapd
process) with a different protocol number.

Closing this socket will then lead to the notification going to nl80211's
socket release notification handler, and possibly cause an action such as
removing a virtual interface.

Fix this issue by checking that the netlink protocol is NETLINK_GENERIC.
Since generic netlink has no notifier chain of its own, we can't fix the
problem more generically.

Fixes: 026331c4d9b5 ("cfg80211/mac80211: allow registering for and sending action frames")
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Ivanov <dima@ubnt.com>
[rewrite commit message]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
net/wireless/nl80211.c