]> git.itanic.dy.fi Git - linux-stable/commit
HID: logitech-hidpp: Stop IO before calling hid_connect()
authorHans de Goede <hdegoede@redhat.com>
Wed, 25 Oct 2023 19:01:51 +0000 (21:01 +0200)
committerBenjamin Tissoires <bentiss@kernel.org>
Thu, 26 Oct 2023 08:06:34 +0000 (10:06 +0200)
commit3e6b0bb22a803532a7ddf8ba255c46213c24a478
tree548ee307cbe45452ae96562e2b311790fd67cdc5
parent9ce363aa009c9ec1b921e3c316cbed7639c024e0
HID: logitech-hidpp: Stop IO before calling hid_connect()

hid_connect() will call hid_pidff_init() which does
hid_device_io_start() leading to an "io already started" warning.

To fix this call hid_device_io_stop() before calling hid_connect(),
stopping IO means that connect events may be lost while hid_connect()
runs, re-enable IO and move the hidpp_connect_event() work queuing
after the hid_connect().

Note re-enabling IO is also necessary for the g920_get_config()
call later during hidpp_probe().

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20231025190151.302376-1-hdegoede@redhat.com
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
drivers/hid/hid-logitech-hidpp.c