]> git.itanic.dy.fi Git - linux-stable/commit
nouveau/gsp/r535: Fix a NULL vs error pointer bug
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 8 Nov 2023 07:40:21 +0000 (10:40 +0300)
committerDanilo Krummrich <dakr@redhat.com>
Tue, 14 Nov 2023 21:40:25 +0000 (22:40 +0100)
commit42bd415bd8bd43721d423930b4695c565661e687
tree66793ed871d230df248ef938a05183914376686a
parent09f12bf9f790052710bd6e48a1fc1bc4d9e17389
nouveau/gsp/r535: Fix a NULL vs error pointer bug

The r535_gsp_cmdq_get() function returns error pointers but this code
checks for NULL.  Also we need to propagate the error pointer back to
the callers in r535_gsp_rpc_get().  Returning NULL will lead to a NULL
pointer dereference.

Fixes: 176fdcbddfd2 ("drm/nouveau/gsp/r535: add support for booting GSP-RM")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Danilo Krummrich <dakr@redhat.com>
Signed-off-by: Danilo Krummrich <dakr@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/f71996d9-d1cb-45ea-a4b2-2dfc21312d8c@kili.mountain
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c