]> git.itanic.dy.fi Git - linux-stable/commit
drm/amdgpu: don't use ATRM for external devices
authorAlex Deucher <alexander.deucher@amd.com>
Tue, 17 Oct 2023 19:40:01 +0000 (15:40 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 3 Nov 2023 15:59:13 +0000 (11:59 -0400)
commit432e664e7c98c243fab4c3c95bd463bea3aeed28
tree7ac67826131c317b4ce4db3b194c3e4afb42b404
parentb3c942bb6c32a8ddc1d52ee6bc24b8cf732dddf4
drm/amdgpu: don't use ATRM for external devices

The ATRM ACPI method is for fetching the dGPU vbios rom
image on laptops and all-in-one systems.  It should not be
used for external add in cards.  If the dGPU is thunderbolt
connected, don't try ATRM.

v2: pci_is_thunderbolt_attached only works for Intel.  Use
    pdev->external_facing instead.
v3: dev_is_removable() seems to be what we want

Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2925
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c