]> git.itanic.dy.fi Git - linux-stable/commit
perf dlfilter: Avoid leak in v0 API test use of resolve_address()
authorAdrian Hunter <adrian.hunter@intel.com>
Wed, 30 Aug 2023 09:05:39 +0000 (12:05 +0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 31 Aug 2023 02:03:03 +0000 (23:03 -0300)
commit45210e1ada6d7889e573e993b66ed0e958aaa8ec
tree037020f2efca19bc682e3c1a5d8481377b1f2347
parentf0005f1732245533f0bfa5bad4803c30a0e9f4e0
perf dlfilter: Avoid leak in v0 API test use of resolve_address()

The introduction of reference counting causes the v0 API
perf_dlfilter_fns.resolve_address() to leak.

v2 API introduced perf_dlfilter_fns.al_cleanup() to prevent that.

For the v0 API, avoid the leak by exiting the addr_location immediately,
since the documentation makes it clear that pointers obtained via
perf_dlfilter_fns are not necessarily valid (dereferenceable) after
'filter_event' and 'filter_event_early' return.

Reported-by: kernel test robot <oliver.sang@intel.com>
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Closes: https://lore.kernel.org/oe-lkp/202308232146.94d82cb4-oliver.sang@intel.com
Link: http://lore.kernel.org/lkml/20230830090539.68206-1-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/dlfilter.c