]> git.itanic.dy.fi Git - linux-stable/commit
iwlwifi: Fix double-free problems in iwl_req_fw_callback()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Wed, 29 May 2019 13:39:54 +0000 (16:39 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 21 Jul 2019 07:04:20 +0000 (09:04 +0200)
commit461117876d9087cc018328f6636e4ae82b58b508
tree8a89bd7f0cb2dafd0975f2ea424abfce608ac502
parentd50f6b58d7ad30ad8e96c0bbc3e5ecfe9b91ba77
iwlwifi: Fix double-free problems in iwl_req_fw_callback()

[ Upstream commit a8627176b0de7ba3f4524f641ddff4abf23ae4e4 ]

In the error handling code of iwl_req_fw_callback(), iwl_dealloc_ucode()
is called to free data. In iwl_drv_stop(), iwl_dealloc_ucode() is called
again, which can cause double-free problems.

To fix this bug, the call to iwl_dealloc_ucode() in
iwl_req_fw_callback() is deleted.

This bug is found by a runtime fuzzing tool named FIZZER written by us.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/intel/iwlwifi/iwl-drv.c