]> git.itanic.dy.fi Git - linux-stable/commit
xfrm: don't check the default policy if the policy allows the packet
authorSabrina Dubroca <sd@queasysnail.net>
Tue, 4 Apr 2023 13:12:16 +0000 (15:12 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 May 2023 16:36:48 +0000 (17:36 +0100)
commit46f1a953545f03cafa76f231c159e6d4d4187c0b
tree868cf15e4260537733cf008e5ede7a075fcb8e5a
parent98f179c5b072ccfd3cfdf1646c0720731d1edba2
xfrm: don't check the default policy if the policy allows the packet

[ Upstream commit 430cac487400494c19a8b85299e979bb07b4671f ]

The current code doesn't let a simple "allow" policy counteract a
default policy blocking all incoming packets:

    ip x p setdefault in block
    ip x p a src 192.168.2.1/32 dst 192.168.2.2/32 dir in action allow

At this stage, we have an allow policy (with or without transforms)
for this packet. It doesn't matter what the default policy says, since
the policy we looked up lets the packet through. The case of a
blocking policy is already handled separately, so we can remove this
check.

Fixes: 2d151d39073a ("xfrm: Add possibility to set the default to block if we have no policy")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/xfrm/xfrm_policy.c