]> git.itanic.dy.fi Git - linux-stable/commit
mlxsw: spectrum_router: Clear offload indication from IPv6 nexthops on abort
authorIdo Schimmel <idosch@mellanox.com>
Fri, 7 Feb 2020 17:26:26 +0000 (19:26 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 7 Feb 2020 17:47:01 +0000 (18:47 +0100)
commit490f0542a7f75572c841afa92da83b549e7d47f9
tree42b4a0107b6ea456eaf26b8f9051b4fe8469b64e
parent6c05ca26f1153b4346ffd03cf65910ecc9cabbbf
mlxsw: spectrum_router: Clear offload indication from IPv6 nexthops on abort

Unlike IPv4, in IPv6 there is no unique structure to represent the
nexthop and both the route and nexthop information are squashed to the
same structure ('struct fib6_info'). In order to improve resource
utilization the driver consolidates identical nexthop groups to the same
internal representation of a nexthop group.

Therefore, when the offload indication of a nexthop changes, the driver
needs to iterate over all the linked fib6_info and toggle their offload
flag accordingly.

During abort, all the routes are removed from the device and unlinked
from their nexthop group. The offload indication is cleared just before
the group is destroyed, but by that time no fib6_info is linked to the
group and the offload indication remains set.

Fix this by clearing the offload indication just before dropping the
reference from the nexthop.

Fixes: ee5a0448e72b ("mlxsw: spectrum_router: Set hardware flags for routes")
Reported-by: Alex Kushnarov <alexanderk@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Tested-by: Alex Kushnarov <alexanderk@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c