]> git.itanic.dy.fi Git - linux-stable/commit
inet: frags: get rif of inet_frag_evicting()
authorEric Dumazet <edumazet@google.com>
Wed, 10 Oct 2018 19:29:58 +0000 (12:29 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Oct 2018 07:13:24 +0000 (09:13 +0200)
commit49106f36c253a3c4ce7cf297415826af0c4339ea
treee6490841efc12b3aaccaa6d4226356b05ea3d5ae
parentea7496f018adcfbac5396ead5756dcabb9866749
inet: frags: get rif of inet_frag_evicting()

This refactors ip_expire() since one indentation level is removed.

Note: in the future, we should try hard to avoid the skb_clone()
since this is a serious performance cost.
Under DDOS, the ICMP message wont be sent because of rate limits.

Fact that ip6_expire_frag_queue() does not use skb_clone() is
disturbing too. Presumably IPv6 should have the same
issue than the one we fixed in commit ec4fbd64751d
("inet: frag: release spinlock before calling icmp_send()")

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 399d1404be660d355192ff4df5ccc3f4159ec1e4)
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/net/inet_frag.h
net/ipv4/ip_fragment.c
net/ipv6/reassembly.c