]> git.itanic.dy.fi Git - linux-stable/commit
scsi: sun3x_esp: Add IRQ check
authorSergey Shtylyov <s.shtylyov@omprussia.ru>
Tue, 30 Mar 2021 17:44:08 +0000 (20:44 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 May 2021 08:38:24 +0000 (10:38 +0200)
commit4aff784e937e9b519d94fe06a2ab5bd5ba4ce539
treed2853d02ee46aec7269eee9f1ac378e7ef43f251
parent1dc0a24e458d1329a869cbd036d2a7d358c41175
scsi: sun3x_esp: Add IRQ check

[ Upstream commit 14b321380eb333c82853d7d612d0995f05f88fdc ]

The driver neglects to check the result of platform_get_irq()'s call and
blithely passes the negative error codes to request_irq() (which takes
*unsigned* IRQ #), causing it to fail with -EINVAL, overriding the real
error code.  Stop calling request_irq() with the invalid IRQ #s.

Link: https://lore.kernel.org/r/363eb4c8-a3bf-4dc9-2a9e-90f349030a15@omprussia.ru
Fixes: 0bb67f181834 ("[SCSI] sun3x_esp: convert to esp_scsi")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/sun3x_esp.c