]> git.itanic.dy.fi Git - linux-stable/commit
um: port_kern: fix -Wmissing-variable-declarations
authorNick Desaulniers <ndesaulniers@google.com>
Tue, 8 Aug 2023 17:31:45 +0000 (10:31 -0700)
committerRichard Weinberger <richard@nod.at>
Sat, 26 Aug 2023 20:44:37 +0000 (22:44 +0200)
commit4b038701e3dd02091e1086bdd89e31e16ceb8e04
treee7bc29918e2235e0f5c68c55dd04cbaa33cbc936
parentb10eee784c767975d345540e5569bdad31b9aec3
um: port_kern: fix -Wmissing-variable-declarations

I'm looking to enable -Wmissing-variable-declarations behind W=1. 0day
bot spotted the following instance:

  arch/um/drivers/port_kern.c:147:14: warning: no previous extern
  declaration for non-static variable 'port_work'
  [-Wmissing-variable-declarations]
  DECLARE_WORK(port_work, port_work_proc);
               ^
  arch/um/drivers/port_kern.c:147:1: note: declare 'static' if the
  variable is not intended to be used outside of this translation unit
  DECLARE_WORK(port_work, port_work_proc);
  ^

This symbol is not referenced by more than one translation unit, so give
it static storage.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/llvm/202308081050.sZEw4cQ5-lkp@intel.com/
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
arch/um/drivers/port_kern.c