]> git.itanic.dy.fi Git - linux-stable/commit
net: mscc: ocelot: don't report that RX timestamping is enabled by default
authorVladimir Oltean <vladimir.oltean@nxp.com>
Tue, 27 Jun 2023 16:31:12 +0000 (19:31 +0300)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 29 Jun 2023 10:40:27 +0000 (12:40 +0200)
commit4fd44b82b7aceaa35c2901c6546d2c4198e0799d
tree6cb1af8fd9dbd6d6edf811d4f8d6044fc5dd6a10
parent3c4bb45ab29303265a8c6d7099e00c824503c586
net: mscc: ocelot: don't report that RX timestamping is enabled by default

PTP RX timestamping should be enabled when the user requests it, not by
default. If it is enabled by default, it can be problematic when the
ocelot driver is a DSA master, and it sidesteps what DSA tries to avoid
through __dsa_master_hwtstamp_validate().

Additionally, after the change which made ocelot trap PTP packets only
to the CPU at ocelot_hwtstamp_set() time, it is no longer even true that
RX timestamping is enabled by default, because until ocelot_hwtstamp_set()
is called, the PTP traps are actually not set up. So the rx_filter field
of ocelot->hwtstamp_config reflects an incorrect reality.

Fixes: 96ca08c05838 ("net: mscc: ocelot: set up traps for PTP packets")
Fixes: 4e3b0468e6d7 ("net: mscc: PTP Hardware Clock (PHC) support")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/mscc/ocelot_ptp.c