]> git.itanic.dy.fi Git - linux-stable/commit
vrf: Remove unnecessary RCU-bh critical section
authorIdo Schimmel <idosch@nvidia.com>
Mon, 21 Aug 2023 14:23:39 +0000 (17:23 +0300)
committerJakub Kicinski <kuba@kernel.org>
Tue, 22 Aug 2023 17:58:50 +0000 (10:58 -0700)
commit504fc6f4f7f681d2a03aa5f68aad549d90eab853
tree0a0af2f30c536c6639311942952fefeabda1033a
parent63c11dc2ca8bf5d8fb85a29db7d23ae083c919df
vrf: Remove unnecessary RCU-bh critical section

dev_queue_xmit_nit() already uses rcu_read_lock() / rcu_read_unlock()
and nothing suggests that softIRQs should be disabled around it.
Therefore, remove the rcu_read_lock_bh() / rcu_read_unlock_bh()
surrounding it.

Tested using [1] with lockdep enabled.

[1]
 #!/bin/bash

 ip link add name vrf1 up type vrf table 100
 ip link add name veth0 type veth peer name veth1
 ip link set dev veth1 master vrf1
 ip link set dev veth0 up
 ip link set dev veth1 up
 ip address add 192.0.2.1/24 dev veth0
 ip address add 192.0.2.2/24 dev veth1
 ip rule add pref 32765 table local
 ip rule del pref 0
 tcpdump -i vrf1 -c 20 -w /dev/null &
 sleep 10
 ping -i 0.1 -c 10 -q 192.0.2.2

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: David Ahern <dsahern@kernel.org>
Link: https://lore.kernel.org/r/20230821142339.1889961-1-idosch@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/vrf.c