]> git.itanic.dy.fi Git - linux-stable/commit
cpupower: Fix segfault due to incorrect getopt_long arugments
authorJosh Boyer <jwboyer@redhat.com>
Fri, 11 Oct 2013 12:45:51 +0000 (08:45 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 15 Feb 2014 19:20:14 +0000 (19:20 +0000)
commit509ec6b9b497aaac9cbf6a7c7ecdf08116807e8f
tree2d01ebc920e2f96a256dcb380734af0a996d0406
parent5982c7fe4acf612e50738475c2c7f2eb47ec7ec2
cpupower: Fix segfault due to incorrect getopt_long arugments

commit f447ef4a56dee4b68a91460bcdfe06b5011085f2 upstream.

If a user calls 'cpupower set --perf-bias 15', the process will end with
a SIGSEGV in libc because cpupower-set passes a NULL optarg to the atoi
call.  This is because the getopt_long structure currently has all of
the options as having an optional_argument when they really have a
required argument.  We change the structure to use required_argument to
match the short options and it resolves the issue.

This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1000439

Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: Thomas Renninger <trenn@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
tools/power/cpupower/utils/cpupower-set.c