]> git.itanic.dy.fi Git - linux-stable/commit
net/sched: act_mirred: use the backlog for mirred ingress
authorJakub Kicinski <kuba@kernel.org>
Thu, 15 Feb 2024 14:33:45 +0000 (06:33 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 16 Feb 2024 10:13:31 +0000 (10:13 +0000)
commit52f671db18823089a02f07efc04efdb2272ddc17
treeb54b82f68061d177ac33b18f53a81fd1a84f4bf2
parenta9f80df4f51440303d063b55bb98720857693821
net/sched: act_mirred: use the backlog for mirred ingress

The test Davide added in commit ca22da2fbd69 ("act_mirred: use the backlog
for nested calls to mirred ingress") hangs our testing VMs every 10 or so
runs, with the familiar tcp_v4_rcv -> tcp_v4_rcv deadlock reported by
lockdep.

The problem as previously described by Davide (see Link) is that
if we reverse flow of traffic with the redirect (egress -> ingress)
we may reach the same socket which generated the packet. And we may
still be holding its socket lock. The common solution to such deadlocks
is to put the packet in the Rx backlog, rather than run the Rx path
inline. Do that for all egress -> ingress reversals, not just once
we started to nest mirred calls.

In the past there was a concern that the backlog indirection will
lead to loss of error reporting / less accurate stats. But the current
workaround does not seem to address the issue.

Fixes: 53592b364001 ("net/sched: act_mirred: Implement ingress actions")
Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Suggested-by: Davide Caratti <dcaratti@redhat.com>
Link: https://lore.kernel.org/netdev/33dc43f587ec1388ba456b4915c75f02a8aae226.1663945716.git.dcaratti@redhat.com/
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/act_mirred.c
tools/testing/selftests/net/forwarding/tc_actions.sh