]> git.itanic.dy.fi Git - linux-stable/commit
PCI/DPC: Await readiness of secondary bus after reset
authorLukas Wunner <lukas@wunner.de>
Sun, 15 Jan 2023 08:20:33 +0000 (09:20 +0100)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 9 Feb 2023 18:46:15 +0000 (12:46 -0600)
commit53b54ad074de1896f8b021615f65b27f557ce874
tree7283b16d68497a9da6f1571b85e19bcd0db54ced
parentac91e6980563ed53afadd925fa6585ffd2bc4a2c
PCI/DPC: Await readiness of secondary bus after reset

pci_bridge_wait_for_secondary_bus() is called after a Secondary Bus
Reset, but not after a DPC-induced Hot Reset.

As a result, the delays prescribed by PCIe r6.0 sec 6.6.1 are not
observed and devices on the secondary bus may be accessed before
they're ready.

One affected device is Intel's Ponte Vecchio HPC GPU.  It comprises a
PCIe switch whose upstream port is not immediately ready after reset.
Because its config space is restored too early, it remains in
D0uninitialized, its subordinate devices remain inaccessible and DPC
recovery fails with messages such as:

  i915 0000:8c:00.0: can't change power state from D3cold to D0 (config space inaccessible)
  intel_vsec 0000:8e:00.1: can't change power state from D3cold to D0 (config space inaccessible)
  pcieport 0000:89:02.0: AER: device recovery failed

Fix it.

Link: https://lore.kernel.org/r/9f5ff00e1593d8d9a4b452398b98aa14d23fca11.1673769517.git.lukas@wunner.de
Tested-by: Ravi Kishore Koppuravuri <ravi.kishore.koppuravuri@intel.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: stable@vger.kernel.org
drivers/pci/pci.c
drivers/pci/pci.h
drivers/pci/pcie/dpc.c